Closed tom-anders closed 2 months ago
While I think it is a good change, we must be careful it doesn't break some screens. We should make a list of all impacted screens and check they still look fine.
Space around is the same as Expanded
if all the children are wrapped in an Expanded
. This may be not the case everywhere (and is why I used Expanded
instead of spaceAround
I believe), as you might want to expand some buttons only.
While I think it is a good change, we must be careful it doesn't break some screens. We should make a list of all impacted screens and check they still look fine.
I'll add Screenshots for all impacted screens. 👍
Space around is the same as
Expanded
if all the children are wrapped in anExpanded
. This may be not the case everywhere (and is why I usedExpanded
instead ofspaceAround
I believe), as you might want to expand some buttons only.
Yeah that's why I exposed the mainAxisAlignment
property, so expanding only one of the buttons should still be possible. However, all the current bottoms bars seems to either use spaceAround
alignment or Expanded
for all buttons. I'll double check once again though.
Analysis:
Opening Explorer:
Board Editor:
Offline Correspondence:
Archived Game:
Game Loading:
Online Game:
Puzzle Screen:
Puzzle Storm:
Puzzle Streak:
TV:
Thanks for the screenshots @tom-anders !
This gets rid of a lot of code duplication and makes it more straight-forward to build new screens for new features.
Note that the Row in BottomBar now has MainAxisAlignment.spaceAround by default, so it's not necessary anymore to wrap buttons in
Expanded
.