search

lichess-org / mobile

Lichess mobile app v2
GNU General Public License v3.0
1.37k stars 198 forks source link

fix: new lints after flutter upgrade #939

Closed tom-anders closed 3 months ago

tom-anders commented 3 months ago

These new lints block all other PRs currently, but they're straight-forward to fix

sorry for spaming PRs while you're gone :grimacing:

tom-anders commented 3 months ago

Seems like https://github.com/letsar/flutter_slidable/pull/484 breaks the build still

tom-anders commented 3 months ago

Huh, so with flutter 3.25 (and after fixing the flutter_slideable error as described in the linked issue) the app now consistently freezes and then crashes my Android emulator after making a move on the analysis board - Downgrading back to flutter 3.24 fixed this, not sure what's going on here. Might (hopefully) be a local issue.

tom-anders commented 3 months ago

Huh, so with flutter 3.25 (and after fixing the flutter_slideable error as described in the linked issue) the app now consistently freezes and then crashes my Android emulator after making a move on the analysis board - Downgrading back to flutter 3.24 fixed this, not sure what's going on here. Might (hopefully) be a local issue.

Setting up a new emulator from scratch solved this, probably a local issue indeed (I use arch btw)

veloce commented 3 months ago

@tom-anders not sure why but tests are failing here.