lichess-org / pgn-mule

Merge, filter, tweak and expose PGN sources
GNU Affero General Public License v3.0
14 stars 11 forks source link

replace `request` with `node-fetch` #30

Open kraktus opened 9 months ago

SergioGlorias commented 1 month ago

fetch is already native to node, you just need to write and remove dependency

ornicar commented 1 month ago

friendly word of advice, many devs don't like the word "just" as it downplays the difficulty of doing something, that might not be that easy.

SergioGlorias commented 1 month ago

friendly word of advice, many devs don't like the word "just" as it downplays the difficulty of doing something, that might not be that easy.

Oh sorry, the meaning is that you no longer need to import a dependency because it is already native to node.js
Of course, in the current state it is necessary to rewrite and update the dependencies. Just an npm i on the updated node already generates an error