search

lichie567 / XIVAuras

Dalamud plugin for tracking buffs, debuffs and cooldowns in FFXIV.
GNU General Public License v3.0
63 stars 40 forks source link

Added option to StatusTrigger to check if TriggerSource is an enemy/friendly GameObject #30

Closed ShepardToTheStars closed 2 years ago

ShepardToTheStars commented 2 years ago

I've looked everywhere in the XIVAura config and didn't see an option to trigger an aura for only friendly units or enemy units. My use case is: as a healer, I want an aura that tells me if my target is missing my DoT, BUT only if the target is an enemy unit. Currently, if I switch off to cast an action on a friendly target, my DoT aura shows up even though they are a friendly target (and I cant use Combust III on a friendly unit lol).

I'm not attached to any of the nomenclature or terminology I used, so if you feel this is a good change but don't like the wording I used, just let me know and I'll change it.

Below are example screenshots of the config and an aura that only triggers when I target an enemy. If the TriggerSource is Player, then the config option is hidden and ignored to prevent weird behavior. Enemy Targeted EnemyTargetted

Friendly Target (Aura should not be triggered) FriendlyTargetted

ShepardToTheStars commented 2 years ago

@lichie567 In case you have not seen this.

lichie567 commented 2 years ago

@ShepardToTheStars sorry I didn't check for pull requests for a very long time. I am willing to accept this change, but please create a PR against the develop branch instead.

ShepardToTheStars commented 2 years ago

@ShepardToTheStars sorry I didn't check for pull requests for a very long time. I am willing to accept this change, but please create a PR against the develop branch instead.

No problem. I had just been using my own fork for a while, but Im glad to hear you're considering it! 😄