licht1stein / obsidian.el

Obsidian Notes for Emacs
GNU General Public License v3.0
362 stars 27 forks source link

Package uses f.el without declaring the dependency, I think #87

Closed fiddlemath closed 2 months ago

fiddlemath commented 8 months ago

I haven't looked deeply into the code, but I just did a fresh install of obsidian.el from MELPA. Following a wikilink to an not-yet-existing file (one of the first things I tried) failed because it couldn't find f-mkdir-full-path, a function from f.el.

I did not have f.el installed; after installing it from MELPA things worked fine.

jayemar commented 8 months ago

f is the first thing required by obsidian.el. Interesting that it wasn't installed for you after a fresh install.

https://github.com/licht1stein/obsidian.el/blob/24ff6ef051ba1f1a1e80a2132fdada37e77eaad6/obsidian.el#L39

jayemar commented 2 months ago

Closing as require statement already present to include required library