search

licoffe / POE-sniper

A cross-platform open source Path of Exile item sniper with a user friendly interface
Other
88 stars 19 forks source link

Allow to export/import filters #10

Closed licoffe closed 7 years ago

gdneye commented 7 years ago

Feature Request

Hey Licoffe, I've been out of town for a bit over a week, so apologies for not closing out old tickets. I'm back and downloaded the latest version. The new features are nice and so far the program seems to be running more smoothly. I really like the import filter function, but noticed that it doesn't import the price from the filter. This isn't huge, and may be by design, but my personal preference would be to include the price in the import as I am currently importing the filter, then adding the price.

Regardless, thanks for building a really nice sniping tool.

licoffe commented 7 years ago

I'm already importing the max price from poe.trade as you can see here but it looks like I introduced some regression by mistake :(

gdneye commented 7 years ago

Interesting... not sure what I'm doing wrong here...

https://youtu.be/EPyTqxXb8DM

Sorry for the crap quality, I'm going to learn how to upload in hd right now.

licoffe commented 7 years ago

It's not on your side :) I introduced some regression by mistake in the code. Changed something, probably to add a feature and it broke some other functions. I'm investigating it.

licoffe commented 7 years ago

I found the culprit. For some reason "data.buyout_max" became "data.buyout.max" and it just stopped working XD It will be fixed in the next release and there will definitely be a release before the next race tomorrow.