search

licoffe / POE-sniper

A cross-platform open source Path of Exile item sniper with a user friendly interface
Other
88 stars 19 forks source link

[Bug - Error] Error on clicking the trash icon next to a filter. #52

Closed xkomachi closed 7 years ago

xkomachi commented 7 years ago

Upon clicking the trash icon next to a filter, the following error pops up:

Windows cannot find '#!'. Make sure you typed the name correctly, and then try again.

The console logs "clearing" and shows no errors.

licoffe commented 7 years ago

This should be fixed in the last commit.

xkomachi commented 7 years ago

Doesn't result in an error anymore, but clicking it does nothing. It's supposed to delete selected filters from what I can understand?

licoffe commented 7 years ago

It should remove the entries found by that filter from the list :)

xkomachi commented 7 years ago

Oh. Well, works :) Not totally related to this issue - I don't have a draft for it, but do you think further down the road being able to have fine control over individual filters is a goal of the project? I mean like your own code for importing/exporting filters; Being able to put filters in folders and add tags to a filter, then search, activate, or disable filters by their tag/location in the folder hierarchy; Defined interactions/priority lists for filters that are a subset of one another or potentially share results, etc.

licoffe commented 7 years ago

Sure, I actually had some other suggestions (see #36) regarding filter customization by the users. I guess for now, I will mostly focus on increasing stability/performances but after that sure. I really like the idea!