search

licongshen12 / pe

0 stars 0 forks source link

Emails are overvalidated #2

Open licongshen12 opened 12 months ago

licongshen12 commented 12 months ago

Description

Emails with special characters (e.g. Latin alphabet with diacritics) are not accepted. In accordance to RFC 6530, emails with such special characters are valid emails and should be accepted. Since NUS allows its students and staff to change their email handles, it is expected that international students might make use of such characters in their emails.

Steps to reproduce

  1. Execute add n/Pele p/98765432 e/Pelé@u.nus.edu th/john_doe123 t/friends t/owesMoney gt/RA1:0 | RA2:0 | MidTerms:0 | Finals:0 | PE:0

Expected behaviour

Student Pelé with email Pelé@u.nus.edu is added into the system.

Actual behaviour

Screenshot 2023-11-17 at 4.37.14 PM.png

soc-pe-bot commented 12 months ago

Team's Response

Thank you for raising this issue. However, users could simply input the student's NUS Net ID number.

Screenshot (380).png

As explained above, using a student's NUS Net ID number in the email will still be able to reach the student. Moreover, as our target users are CS1101S Avengers, users will all receive their student's NUS Net ID number. Hence, we think this bug is invalid.

Warmest Regards,

Team F.A.K.E.J.A.R.V.I.S.

logofj (2).png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]