search

licq-im / licq

An instant messaging client for UNIX
http://www.licq.org/
16 stars 4 forks source link

licq-qt4-plugin 1.8.0 fails to build on OS X in licqui.cpp #35

Closed nieder closed 10 years ago

nieder commented 10 years ago

I'm on OS X 10.7 with Qt4.7 (and also failed similary with 4.8). I'm using clang as my compiler, but the failure also happens with gcc-4.8.

[ 43%] Building CXX object src/CMakeFiles/licq_qt4-gui.dir/core/licqgui.o
cd /sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/finkbuild/src && /sw/var/lib/fink/path-prefix-clang/c++   -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB -D_REENTRANT -Dlicq_qt4_gui_EXPORTS -MD  -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk -mmacosx-version-min=10.7 -fPIC -I/sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/finkbuild -I/sw/include/boost-1_53 -I/sw/include -I/sw/include/licq -isystem /sw/lib/qt4-mac/include -F/sw/lib/qt4-mac/lib -isystem /sw/lib/qt4-mac/include/QtGui -isystem /sw/lib/qt4-mac/include/QtXml -isystem /sw/lib/qt4-mac/lib/QtCore.framework/Headers -I/sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/src    -Wall -Wextra -o CMakeFiles/licq_qt4-gui.dir/core/licqgui.o -c /sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/src/core/licqgui.cpp
/sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/src/core/licqgui.cpp:163:3: error: member initializer 'myPopupMessageKey' does not name a non-static data member or base class
  myPopupMessageKey(0),
  ^~~~~~~~~~~~~~~~~~~~
/sw/build.build/licq-plugin-qt4-1.8.0-1/licq-1.8.0/plugins/qt4-gui/src/core/licqgui.cpp:164:3: error: member initializer 'myShowMainwinKey' does not name a non-static data member or base class
  myShowMainwinKey(0)
  ^~~~~~~~~~~~~~~~~~~
nieder commented 10 years ago

I think this patch will work. It allows compilation to continue, but I am not sure if it actually fixes the problem or just ignores it:

diff -ruN licq-1.8.0-orig/plugins/qt4-gui/src/core/licqgui.cpp licq-1.8.0/plugins/qt4-gui/src/core/licqgui.cpp
--- licq-1.8.0-orig/plugins/qt4-gui/src/core/licqgui.cpp    2013-08-25 05:45:17.000000000 -0400
+++ licq-1.8.0/plugins/qt4-gui/src/core/licqgui.cpp 2013-09-17 19:48:50.000000000 -0400
@@ -159,9 +159,7 @@
 #endif
   myStartHidden(false),
   myDisableDockIcon(false),
-  myUserEventTabDlg(NULL),
-  myPopupMessageKey(0),
-  myShowMainwinKey(0)
+  myUserEventTabDlg(NULL)
 {
   assert(gLicqGui == NULL);
   gLicqGui = this;