search

lidatong / dataclasses-json

Easily serialize Data Classes to and from JSON
MIT License
1.34k stars 151 forks source link

Code Coverage Publish breaks CI on Fork PRs #443

Open george-zubrienko opened 11 months ago

george-zubrienko commented 11 months ago

Apparently GH Actions do not allow fork PR runs to post comments on parent repo. We should skip coverage publishing for forks as a quick workaround

https://github.com/community/community/discussions/25217#discussioncomment-3246902

george-zubrienko commented 11 months ago

@lidatong there is a chance this can be fixed by this https://github.com/MishaKav/pytest-coverage-comment/issues/68#issuecomment-1469626721 - could you test? I honestly do not remember what fixed this in our OSS repos for forks, or if we ever fixed that at all

george-zubrienko commented 11 months ago

as an alternative, I can disable coverage comment with either hide-comment or by disabling the step with

if: ${{ !github.event.pull_request.head.repo.fork }}