search

lidatong / dataclasses-json

Easily serialize Data Classes to and from JSON
MIT License
1.34k stars 150 forks source link

[BUG] Documentation is misleading. #530

Open mahyarmirrashed opened 1 month ago

mahyarmirrashed commented 1 month ago

Description

Documentation says that the latest release is available for Python3.6 but, it is not. Python3.6 support was removed here, on March 18, 2023: https://github.com/lidatong/dataclasses-json/commit/77526873ade0424561c60416a3bcb29dde92b302. I am building on a frozen system that is unable to upgrade its Python version. Otherwise, this wouldn't be much of an issue since Python3.6 is EOL anyway. I'd just like to see the text in the README.md where it says that 3.6 is supported to be removed. Thanks.

Code snippet that reproduces the issue

N/A

Describe the results you expected

To

Python version you are using

3.6.9

Environment description

pip==9.0.1

george-zubrienko commented 2 weeks ago

@mahyarmirrashed you are welcome to submit a PR to correct the docs :)

mahyarmirrashed commented 2 weeks ago

@george-zubrienko you're correct! I just wanted to raise it with you before I did something like that. Thanks for confirming, I'll create a PR soon.