Update project structure to keep up with Trillian

lidavidm / astra

CS 5152

0 stars 1 forks source link

Update project structure to keep up with Trillian #3

Open jcao219 opened 7 years ago

jcao219 commented 7 years ago

Trillian has made the following changes (code, latest https://github.com/google/trillian/blob/master/integration/log_integration_test.sh) :

The trillian log_server binary no longer accepts a private key flag and private key password flag. See https://github.com/google/trillian/commit/94fd22f60692606fda8c009500a8d530b8c67288
trillian now can build a binary called ./createtree (see https://github.com/google/trillian/tree/master/cmd/createtree), probably designed to run after the log server is up & running, which creates a tree
a log signer service (https://github.com/google/trillian/tree/master/server/trillian_log_signer) has been refactored into existence, so we need to make a container for that

lidavidm commented 7 years ago

I dunno how we're going to keep using docker-compose now. The createtree script prints out the tree ID; I think we might have to have a more complex trampoline for the CT server, which tries to 1) find the tree ID if it was created; 2) create it if it can't find it; 3) update the config and start the server.

lidavidm commented 7 years ago

Wrote a bit of the new trampoline; looks like we need to patch Trillian again, as the log server now binds to localhost instead of 0.0.0.0.

lidavidm commented 7 years ago

With that patch, now I'm getting this:

failed to create signer for tree: RSA signature not supported by key of type *ecdsa.PrivateKey

lidavidm commented 7 years ago

Alright, it's all been fixed. We need the Trillian patch, and a patch to make createtree wait for the log server to be available.

lidavidm commented 7 years ago

@jcao219 I fixed the CT server to block until the log server is available, is it all working on your end too?

jcao219 commented 7 years ago

createtree is failing with

Failed to create tree: rpc error: code = Unknown desc = Error 1054: Unknown column 'CreateTimeMillis' in 'field list'

lidavidm commented 7 years ago

You might have to recreate all the containers from scratch, they moved a lot of stuff around.

jcao219 commented 7 years ago

It all works now.

jcao219 commented 7 years ago

Well, the log signer is failing every time it tries to sign the empty log. It doesn't do error reporting, so I'm not sure what's the cause.