search

lidel / google-music-hotkeys

Browser extension that adds keyboard control to Google / YouTube Music
https://github.com/lidel/google-music-hotkeys#install
Creative Commons Zero v1.0 Universal
32 stars 5 forks source link

Customizing keyboard shortcuts #1

Closed magnetik closed 6 years ago

magnetik commented 6 years ago

Hi,

Using this addon on firefox, I would like to use the media key instead of some combo on my keyboard.

Is this feasible ?

Thanks

lidel commented 6 years ago

Not yet! It will be possible as soon as Mozilla implements GUI for customizing key shortcuts :) There is are tickets about this: https://bugzilla.mozilla.org/show_bug.cgi?id=1303384 & https://bugzilla.mozilla.org/show_bug.cgi?id=1320332 (feel free to register at Bugzilla and vote for the issue). When implemented, you will be able to change default shortcuts.

(under Chrome shortcuts can be customized at chrome://extensions/configureCommands)

magnetik commented 6 years ago

I voted on bugzilla, thanks for the fast answer :)

raulpopadineti commented 6 years ago

Upvoted as well.

lidel commented 6 years ago

Good news, this will land in Firefox 60:

It is just an API, so after it lands I need to add UI for changing shortcuts in Firefox Probably with help of this example app and lib:

rcdailey commented 6 years ago

Knowing our luck, Firefox 60 will land right about the same time Google replaces Google Play Music with this YouTube Remix crap

rcdailey commented 6 years ago

Firefox 60 has been released!

lidel commented 6 years ago

tumblr_lj57gozvbh1qdjdp1o1_500

lidel commented 6 years ago

Shortcut key customization landed in v1.6.0. Requires Firefox 60 or later.

How To Customize Shortcuts in Firefox >=60

Right-click on Browser Action or Preferences

Right-click on Browser Action

Old school shortcuts can be now changed thanks to webextensions-lib-shortcut-customize-ui:

screenshot with old school shortcuts

A cool feature is that you can also use "media keys" without any modifiers:

screenshot with media key

rcdailey commented 6 years ago

Can these be configured to be global like in chrome?

On Sun, May 13, 2018, 6:45 AM Marcin Rataj notifications@github.com wrote:

Shortcut key customization landed in v1.6.0 https://github.com/lidel/google-music-hotkeys/releases/tag/v1.6.0. Requires Firefox 60 or later. How To Customize Shortcuts in Firefox >=60

Right-click on Browser Action or Preferences

[image: Right-click on Browser Action] https://user-images.githubusercontent.com/157609/39958925-24e00498-560a-11e8-937e-45bc8fbf43eb.png

Old school shortcuts can be now changed thanks to webextensions-lib-shortcut-customize-ui https://github.com/piroor/webextensions-lib-shortcut-customize-ui:

[image: screenshot with old school shortcuts] https://user-images.githubusercontent.com/157609/39966689-5b7e9dce-56b0-11e8-886c-a98c2c3fef0e.png

A cool feature is that you can also use "media keys" without any modifiers:

[image: screenshot with media key] https://user-images.githubusercontent.com/157609/39966694-6abf5b02-56b0-11e8-9ad4-ec1cde02bc29.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lidel/google-music-hotkeys/issues/1#issuecomment-388620900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr6dgyAaZwso7Nnxt3f7GZsPTHCLIlsks5tyBzhgaJpZM4Qdoa_ .

lidel commented 6 years ago

No, Firefox does not provide API for that yet, but there is a ticket requesting it for which you can vote for:

rcdailey commented 6 years ago

Oh boy. Looks like I'm with chrome for a little while longer.

On Sun, May 13, 2018, 7:32 AM Marcin Rataj notifications@github.com wrote:

No, Firefox does not provide API for that yet, but there is a ticket requesting it:

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lidel/google-music-hotkeys/issues/1#issuecomment-388623513, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr6difvxtTjMUBuby_x0FcQrIkRbCupks5tyCfCgaJpZM4Qdoa_ .