lidofinance / alerting-forta

Forta Detection bots for Lido
https://app.forta.network/bots?search=0x6aea36c4a9cf8ac053c07e662fa27e8bdf047121&sort=recent
GNU General Public License v3.0
34 stars 7 forks source link

Fix: new gateseal address #532

Closed TheDZhon closed 2 months ago

TheDZhon commented 2 months ago

See:

The PR changes the default GateSeal instance from 0x1ad5cb2955940f998081c1ef5f5f00875431aa90 to 0x79243345eDbe01A7E42EDfF5900156700d22611c


Discord thread: https://discord.com/channels/761182643269795850/1232298060290330625

TheDZhon commented 2 months ago

I guess we do not have to make code more complicated than we have. So, just switch the address of the GATE_SEAL_DEFAULT_ADDRESS and rename GATE_SEAL_EXPIRY_TRIGGER_EVERY into TWO_WEEKS directly. =)

I am totally agree, though the currently existing tests wouldn't work, and the challenging part is those tests that replicate expiration behavior in the future :thinking: