Closed sergeyWh1te closed 2 months ago
I'll remove it after Friday deploy. I made it for temp back capability with older gateseal address. Also, you could find that only that GATE_SEAL_DEFAULT_ADDRESS_BEFORE_26_APR_2024 directly is exported from constants.ts
I am just wondering how we would shape the tests for the GateSeal expiration alerts :)
I'll try to describe some actions in the codebase:
} catch (e) {
To according eslint rules this "catch" could not be empty block. Yes, sounds resealable. Different side of coin -ethers.utils.Interface([listenAbiEvent]).parseLog
throws Error when current log does not have compatibility with listenAbiEvent.We have list of events by one address like on a picture. But code could not know what exactly Event is placed in array of logs before parsing each one.
I am not sure that we should store this constant tbh No worry. I'll remove it after Friday deploy. I made it for temp back capability with older gateseal address. Also, you could find that only that
GATE_SEAL_DEFAULT_ADDRESS_BEFORE_26_APR_2024
directly is exported from constants.tsRemoved tests that I have wrote. Those tests were written for testing filterLog function provided by FortaSDK. This commit removes this dependency for our custom logic. Also, new code is fully test covered.