Due to the changed version slot position (from CONTRACT_VERSION_POSITION_DEPRECATED to CONTRACT_VERSION_POSITION), it wasn't checked in the Lido V2 branch (#482) that LegacyOracle.finalizeUpgrade_V4 must not be called more than once.
While the protocol itself doesn't rely on this contract anymore, it could have broken external integrations by changing the time specs stored in the contract.
TheDZhon
commented
1 year ago
Due to the changed version slot position (from
CONTRACT_VERSION_POSITION_DEPRECATEDtoCONTRACT_VERSION_POSITION), it wasn't checked in the Lido V2 branch (#482) thatLegacyOracle.finalizeUpgrade_V4must not be called more than once.While the protocol itself doesn't rely on this contract anymore, it could have broken external integrations by changing the time specs stored in the contract.
The issue is resolved in #705
Regression was introduced in https://github.com/lidofinance/lido-dao/commit/1e643f08d77c410668730a0ab9935954103becc4