search

lidofinance / core

Lido DAO smart contracts
https://lido.fi
GNU General Public License v3.0
382 stars 193 forks source link

Fix: typos #817

Closed vuittont60 closed 10 months ago

vuittont60 commented 10 months ago

fix: typos in test/ fix: typos in gasprofile/ fix: typos in contracts/ fix: typos in apps/node-operators-registry/ fix: typos in apps/lidooracle/ fix: typos in apps/lido/

arwer13 commented 10 months ago

Thank you for the fixes, LGTM!

But please target develop branch, to follow the usual process: changes between on-chain releases go to develop first (and develop merged to master once the contracts are updated onchain).

⚠️ NB, there is a change in the contract deployed on-chain on mainnet (WithdrawalsManagerProxy). To keep correspondence between on-chain code and code in the repo in master branch we don't change contracts code. But this contract is an exception because it has been modified to support the scratch deployment. Thus I recon it is okay to change typos in it.