lidofinance / core

Lido DAO smart contracts
https://lido.fi
GNU General Public License v3.0
382 stars 193 forks source link

Update deploy script to include SepoliaDepositAdapter contract upgrade #824

Closed vp4242 closed 9 months ago

vp4242 commented 9 months ago

Update deploy script to include SepoliaDepositAdapter contract upgrade

arwer13 commented 9 months ago

@TheDZhon @vp42ldo There is updateProxyImplementation from deploy.js for the case (if the adapter implementation not deployed yet). It will read the proxy address from the state file, deploy the implementation, bind it to the proxy and update the impl address in the state file.

vp4242 commented 9 months ago

@TheDZhon @vp42ldo There is updateProxyImplementation from deploy.js for the case (if the adapter implementation not deployed yet). It will read the proxy address from the state file, deploy the implementation, bind it to the proxy and update the impl address in the state file.

There is an issue with updateProxyImplementation. DepositContractAdapter and it's proxy are not part of deployed-.json as it's specific for Sepolia-deploy only. Currently there is no reference to the proxy address except a parameter to stakingRouter

arwer13 commented 9 months ago

Oh, we've forgotten to add it to the state file :/ I'd propose to add it now under /depositContractAdapter. It is part of the setup and thus must be presented in the state file as well.

TheDZhon commented 9 months ago

Having it would be prudent, I agree with @arwer13 :pray: