search

lidofinance / lido-keys-api

Api for fetching node operators keys from modules
MIT License
18 stars 15 forks source link

fix: add missing `middleware` package #219

Closed AlexanderLukin closed 8 months ago

AlexanderLukin commented 10 months ago

Add the missing @lido-nextjs/middleware package to the "dependencies" section of the package.json file.

The MiddlewareService symbol from this package is used in the src/common/consensus-provider/consensus-fetch.service.ts file but was not explicitly listed in dependencies. Now it is fixed.

eddort commented 9 months ago

If I understand correctly, this package should additionally be added to the "peerDependencies" in the fetch package. to avoid such problems in the future

AlexanderLukin commented 7 months ago

If I understand correctly, this package should additionally be added to the "peerDependencies" in the fetch package. to avoid such problems in the future

I don't think that we should add @lido-nextjs/middleware to "peerDependencies" of the @lido-nestjs/fetch package because this package is not required. Using the fetcher in middleware is only one of the possible techniques of how the fetcher can be used. It is possible to use the fetcher without defining the middleware. @eddort please, let me know if you disagree.