search

liedekef / events-made-easy

The wordpress plugin events-made-easy to manage events, memberships and more.
https://www.e-dynamics.be/wordpress
GNU General Public License v2.0
24 stars 6 forks source link

Issue with mailing #600

Closed TommieNL closed 2 months ago

TommieNL commented 2 months ago

Hello,

I'm trying to send an event related e-mail.

Ive selected the event All attendees All registered persons A test subject A test Message A mailing name

When sending a test message i'm getting the warning: Enter both subject and message for the email to be sent.

Extra: when re-using an old mailing it works, but I cannot change the body of the text (only the subject).

What am I doing wrong? I'm at 2.4.50

TommieNL commented 2 months ago

Note: by creating a template and using that i'm succesful with sending an test e-mail.

But when i'm trying to send the mailing directly (by note using date/time) it seems the mailing is planned bu with 0 recepients.

image

liedekef commented 2 months ago

Concerning the subject/content: it seems this can be related to the text-part not being initialized correctly. I could replicate it once ... switch from html->text view and see that isn't empty then. I'll check that some more here too. Concerning the "0 e-mails": it seems the count is wrong before the emails are sent, but it is correct when the actual sending takes place :-) Reason is that I no longer insert the individual mails before the mail goes out (because I needed to recount/recheck the recipients before sending anyway), but it means here the count is wrong. I can reproduce that so I'll come up with a fix :-)

liedekef commented 2 months ago

The count issue is fixed here: https://github.com/liedekef/events-made-easy/commit/7dd5bb7c1894455ea22a783d8db6eb3eeded1429

TommieNL commented 2 months ago

Thanks for the quick reply as always!

I was able to send a (test) mail when adding it to templates and using those. I've leaved the data empty to send it direct. But it remains at status "plannend". This is not something I recognize from before (it always sended directly and added it to the mail queue)

Also when I choose a specific time nothing is being send.

Ps. How can I implement your fix above?

TommieNL commented 2 months ago

Hmm maybe I was inpatient... the queue is full now!

liedekef commented 2 months ago

For now I'll close this, new version with the mentioned fix released. If you have more issues with the test email, please report them in a new issue.

liedekef commented 2 months ago

good news: I also found out the reason of the "Enter both subject and message for the email to be sent" issue. I renamed an option but forgot to update certain variables to the new name, causing this issue. I'll release another version to fix this.

TommieNL commented 2 months ago

good news: I also found out the reason of the "Enter both subject and message for the email to be sent" issue. I renamed an option but forgot to update certain variables to the new name, causing this issue. I'll release another version to fix this.

Awesome @liedekef many thanks