search

liefery-it-legacy / bugsnex

API client and logger for Bugsnag
MIT License
10 stars 2 forks source link

Filters everything that is below status code 500 #37

Closed bitboxer closed 5 years ago

bitboxer commented 5 years ago

This is how appsignal and others do the error handling in elixir. Maybe there are use cases where the < 500 errors should be reported. If there are, you can easily add your own error handlers for specific ones or we need to modify the code here to make it configurable.

Ah and this PR also reformats using the elixir formatter. If you don't like it I will have to redo the PR and disable the auto format in my VS Code :trollface: .

closes #36

bitboxer commented 5 years ago

Ah and if you know how to build this in a way that older elixir/phoenix versions are still working and we have cowboy 2 in the tests, I am all 👂

bitboxer commented 5 years ago

Sorry, I totally forgot to fix this PR 🦊 . Now it only has the minimal changes needed. After this is in, there will be another PR to do the mix format and maybe adding something that guarantees that the formatter is run. With ex_check for example.

irmela commented 5 years ago

Thanks a lot @bitboxer 💚

I fixed the CI setup so if you rebase to the current master branch tests should pass.

bitboxer commented 5 years ago

Rebased. Let's see what the good old travis says.

bitboxer commented 5 years ago

Thank you for merging this so quickly.