search

lierdakil / pandoc-crossref

Pandoc filter for cross-references
https://lierdakil.github.io/pandoc-crossref/
GNU General Public License v2.0
952 stars 76 forks source link

For subfigures in LaTeX: subfig incompatible with hyperref -> use subcaption instead? #182

Open gandalfsaxe opened 6 years ago

gandalfsaxe commented 6 years ago

@lierdakil Have you encountered any incompatibility issues between hyperref and subfig? Apparently there are some issues with the two. This is also apparent if you just google "hyperref subfig".

You could consider using subcaption instead of subfig.

Only complication is that subcaption requires caption, which itself have some incompatibilities with some document classes, but from what I can gather, consensus is that the hyperref incompatibility with subfig is a more frequently a problem in general.

Perhaps not something you want to change, but I did notice that you're using hyperref in pandoc-crossref also, so I just wanted you to be aware of it.

lierdakil commented 6 years ago

Personally, didn't encounter any problems, but I don't use hyperref with LaTeX all that often (since I usually produce LaTeX for print, therefore hyperlinks don't make any sense). I don't remember why exactly I chose subfig and not subcaption, but pretty sure because it was just easier for one reason or another (most likely I ran into problems with subcaption). I'll revisit this after I finally get around to polishing #174. In the meantime, PRs are welcome.

gandalfsaxe commented 6 years ago

I haven't used hyperref enough to encounter any problems either. I'd say this could be considered pretty low-priority, at least until someone perhaps encounters problems. If I encounter problems myself, I could dare a PR if I could read the Haskell/LaTeX code well enough.