search

lierdakil / pandoc-crossref

Pandoc filter for cross-references
https://lierdakil.github.io/pandoc-crossref/
GNU General Public License v2.0
909 stars 73 forks source link

Update for pandoc 3.2.1 #443

Closed hseg closed 1 week ago

hseg commented 1 week ago

Bumped dependency versions, fixed golden tests:

Changes whose source I couldn't track down:

hseg commented 1 week ago

hrm, I get the test/m2m/listings-code-block-caption-278/expect.tex failure again when building in a clean chroot. Any ideas what may be going on?

Failures:

  test/test-integrative.hs:56:17: 
  1) Integrative tests, listings-code-block-caption-278, LaTeX
       expected: (3, "\\phantomsection\\label{lst:some_listing}%")
        but got: (3, "\\begin{lstlisting}[caption={some\\_listing}, label=lst:some_listing]")

  To rerun use: --match "/Integrative tests/listings-code-block-caption-278/LaTeX/" --seed 1240477577
lierdakil commented 1 week ago

Thanks for your help. However, you didn't update CI config or cabal freezefile or flake lock. So I can't merge it as is (even ignoring any potential test failures).

There are a few scripts to facilitate this whole thing, see https://github.com/lierdakil/pandoc-crossref?tab=readme-ov-file#how-to-bump-pandoc-version. Consider using those if you're willing to do that in the future.

Anyway, I'll just cherry-pick your commit and go through the necessary movements on my end.

Thanks again, even if I gripe a little, it's very helpful :sweat_smile:

lierdakil commented 1 week ago

To answer your question wrt test/m2m/listings-code-block-caption-278/expect.tex, you need pandoc --listings to regenerate it. mkinttest.sh does this, but for historical reasons it only regenerates *.tex on the master branch. I may amend this quirk while at it.

hseg commented 1 week ago

Ah. The patches originated in my manual attempts to keep things building and passing tests with the new pandoc (thanks for the comprehensive tests, BTW - they boost confidence that my fixes are sufficient), should've checked to see if there was any tooling for this. I'll try to keep this in mind next time this comes up.

El 26 de junio de 2024 17:03:01 GMT+03:00, Nikolay Yakimov @.***> escribió:

Thanks for your help. However, you didn't update CI config or cabal freezefile or flake lock. So I can't merge it as is (even ignoring any potential test failures).

There are a few scripts to facilitate this whole thing, see https://github.com/lierdakil/pandoc-crossref?tab=readme-ov-file#how-to-bump-pandoc-version. Consider using those if you're willing to do that in the future.

Anyway, I'll just cherry-pick your commit and go through the necessary movements on my end.

Thanks again, even if I gripe a little, it's very helpful :sweat_smile:

-- Reply to this email directly or view it on GitHub: https://github.com/lierdakil/pandoc-crossref/pull/443#issuecomment-2191792970 You are receiving this because you authored the thread.

Message ID: @.***>

hseg commented 1 week ago

Hrm. Odd, but OK. Alternatively, perhaps this should be added parenthetically to the "fix tests" step of https://github.com/lierdakil/pandoc-crossref?tab=readme-ov-file#how-to-bump-pandoc-version?

El 26 de junio de 2024 17:27:16 GMT+03:00, Nikolay Yakimov @.***> escribió:

To answer your question wrt test/m2m/listings-code-block-caption-278/expect.tex, you need pandoc --listings to regenerate it. mkinttest.sh does this, but for historical reasons it only regenerates *.tex on the master branch. I may amend this quirk while at it.

-- Reply to this email directly or view it on GitHub: https://github.com/lierdakil/pandoc-crossref/pull/443#issuecomment-2191853405 You are receiving this because you authored the thread.

Message ID: @.***>

lierdakil commented 1 week ago

perhaps this should be added parenthetically to the "fix tests" step

Fair enough.