Closed alevesely closed 3 years ago
lieser
commented
3 years ago Thanks a lot for reporting. Seems to be a bug how the quoted AUID (header.i="dkim+MSA-tls@aegee.org") inside one of the ARHs is handled by the add-on.
Note as ARHs that cause this bug do not seem to be common, I do not plan to fix it in an 3.x.x version, but only in the upcoming 4.0.0.
lieser
commented
3 years ago Note that if ARH reading is not enabled just to avoid local DKIM verifications, try disabling Reading the Authentication-Results header replaces the add-ons verification in the advanced option as a woraround,
alevesely
commented
3 years ago Now I'm running DKIM Verifier 4.0.0pre4 of December 29, 2020, with TB 78.6.0 .
I tried to open the same message that caused that error. Although I have debug enabled, the error console shows only this:
WebExtensions: DKIM: from address not found (no firstChild) 2 dkimHeader.js:620
DKIM_Verifier.background FATAL Unexpected error during onMessageDisplayed Error: expected errorType on PERMFAIL result
dkimSigResultV2_to_AuthResultDKIM moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/modules/AuthVerifier.mjs.js:532
SavedAuthResult_to_AuthResult moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/modules/AuthVerifier.mjs.js:640
verify moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/modules/AuthVerifier.mjs.js:172
background.mjs.js:164:7
<anonymous> moz-extension://694bf5d4-0ccd-4013-88d6-a4fdb3a218aa/content/background.mjs.js:164FWIW, the From: line was:
From: =?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?=
<dilyan.palauzov@aegee.org>Curiously, I cannot reach DKIM Verifier's options. It doesn't show in Tools/ Add-on Options. I have to use Config Editor and search for dkim_verifier. I have this (using grep on prefs.js):
user_pref("extensions.dkim_verifier.arh.read", true);
user_pref("extensions.dkim_verifier.colorFrom", true);
user_pref("extensions.dkim_verifier.debug", true);
user_pref("extensions.dkim_verifier.dns.libunbound.path", "/usr/lib/x86_64-linux-gnu/libunbound.so.8");
user_pref("extensions.dkim_verifier.dns.libunbound.path.relToProfileDir", false);
user_pref("extensions.dkim_verifier.dns.nameserver", "172.25.197.1");
user_pref("extensions.dkim_verifier.dns.resolver", 2);
user_pref("extensions.dkim_verifier.error.detailedReasons", true);
user_pref("extensions.dkim_verifier.error.illformed_i.treatAs", 2);
user_pref("extensions.dkim_verifier.error.key_testmode.ignore", true);
user_pref("extensions.dkim_verifier.showDKIMFromTooltip", 50);
user_pref("extensions.dkim_verifier.showDKIMStatusbarpanel", 40);
user_pref("mail.server.server2.dkim_verifier.arh.allowedAuthserv", "wmail.tana.it tana.it");
user_pref("mail.server.server2.dkim_verifier.arh.read", 1);
user_pref("mail.server.server2.dkim_verifier.dkim.enable", 1);I'm not clear what should I try to change...
lieser
commented
3 years ago I only go to fix this issue yesterday, so in 4.0.0pre4 it is still broken. Just uploaded a 4.0.0pre4.1 at https://github.com/lieser/dkim_verifier/issues/199#issuecomment-774676192, there the issue with quoted AUID is fixed.
The issue you just reported seems to be something else, will look into it.
Regarding the options: I know it is a little confusing, but the normal way add-ons options are shown in TB 78 is no longer the Tools > Add-on Options menu, like it was in TB 68. You do that now in the add-on manager, see https://support.mozilla.org/en-US/kb/thunderbird-add-ons-frequently-asked-questions#w_how-do-i-configure-add-ons
The prefs.js is the old storage location for the options, and no longer accessible by normal means in WebExtensions. The new location is storage.local, a WebExtension API (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/local).
prefs.js is only used ones at the beginning to migrate the options to the new location, and is afterwards ignored. For now, I decided against an automatic cleanup.
Something similar applies to the dkimKey.sqlite and dkimPolicy.sqlite store the add-on added to the profile in previous versions.
lieser
commented
3 years ago The error you saw seems to be a duplicate of #232, which should also be fixed in 4.0.0pre4.1.
alevesely
commented
3 years ago Yup, version 4.0.0pre4.1 of February 8, 2021 works well. Thank you very much!
I copy some text from the console, in case it's useful.
WebExtensions: DKIM: from address not found (no firstChild) 2 dkimHeader.js:620
DKIM_Verifier.AuthVerifier DEBUG ARH result:
{…}
dkim: (3) […]
0: {…}
auid: "dkim+MSA-tls@aegee.org"
favicon: undefined
res_num: 10
result: "SUCCESS"
result_str: "Valid (Signed by aegee.org)"
sdid: "aegee.org"
version: "2.0"
warnings: []
length: 0
<prototype>: Array []
warnings_str: Array []
<prototype>: Object { … }
1: Object { version: "2.0", result: "SUCCESS", sdid: "ietf.org", … }
2: Object { version: "2.0", result: "SUCCESS", sdid: "ietf.org", … }
length: 3
<prototype>: Array []
dmarc: Array []
spf: Array [ {…} ]
version: "3.0"
<prototype>: Object { … }
AuthVerifier.mjs.js:271:6
DKIM_Verifier.AuthVerifier DEBUG authResult:
{…}
dkim: (3) […]
0: {…}
auid: "dkim+MSA-tls@aegee.org"
favicon: undefined
res_num: 10
result: "SUCCESS"
result_str: "Valid (Signed by aegee.org)"
sdid: "aegee.org"
version: "2.0"
warnings: Array []
warnings_str: Array []
<prototype>: Object { … }
1: Object { version: "2.0", result: "SUCCESS", sdid: "ietf.org", … }
2: Object { version: "2.0", result: "SUCCESS", sdid: "ietf.org", … }
length: 3
<prototype>: Array []
dmarc: Array []
spf: Array [ {…} ]
version: "2.1"
<prototype>: Object { … }
AuthVerifier.mjs.js:173:7Thanks for letting me know that it work now. Will close this issue.
The last log you posted seems fine. The DKIM: from address not found (no firstChild) is nothing to worry about.
Here's the log:
A-R fields seem to parse correctly:
Signatures: