search

lieser / dkim_verifier

DKIM Verifier Extension for Mozilla Thunderbird
MIT License
213 stars 36 forks source link

Does not work alongside Gmail-Conversation View #30

Closed yoshimo closed 10 years ago

yoshimo commented 10 years ago

Unfortunately this nice addon is not compatible with https://github.com/protz/GMail-Conversation-View/ . I have to switch to standart-view in that addon to actually see the dkim verification status. I hope that you and @protz can figure out a way to have the addons working alongside together

protz commented 10 years ago

Hey, Thanks for filing a ticket. There's a plugin mechanism in Conversations that allows other addons to interact with Conversations, for instance, by reacting to "message displayed" events, and the like. Enigmail and Lightning authors have both written compatibility plugins for Conversations (the exemples are in Conversation's tree, in the modules/plugins directory). There's a more dated blog post at http://blog.xulforum.org/index.php?post/2010/11/27/Thunderbird-Conversations-plugins that gives a high-level picture of the plugin mechanism.

Please let me know how this works for you; if you find that the API I'm offering is insufficient, I'd be happy to improve it.

Best

~ jonathan

lieser commented 10 years ago

Hi, first thanks to both of you for reporting the issue / the information how to fix it.

I have added a plugin to Conversations (see https://github.com/lieser/GMail-Conversation-View/commit/beadbcec4e7010a6a31bd1a4aff0d8ecee0604b6). conversations_001 The color of the tag changes according to the result. Green for a valid signature without warings, orange for warnings, red for invalid and the default blue for temporary error (like DNS error). For the tag text, which do you prefer: the longer "DKIM signed", or just "DKIM"?

Whats not yet available form the Conversations view are the actions like reverification of the signature. Is this ok, or to you need them too?

If you have any suggestions, please say so. Otherwise I will make a pull request to merge the changes.

Note that if you see in the tooltip the placeholder "%S", it's not an issue in the plugin, but in the DKIM Verifier add-on which will be fixed in version 1.2.1.

protz commented 10 years ago

Hi,

That's awesome news! Thanks :-). This looks great "as is", but I just discovered DKIM verifier a few days ago, so I'm not the best person to tell you if more features are really needed or not :).

I just took a cursory glance at your code and it looks great.

Best,

~ jonathan

yoshimo commented 10 years ago

There is nothing wrong in enhancing the compatibility module later. As long as i am able to see the dkim-check it's ok for now. Wether it is "DKIM" or "DKIM signed" , either is fine with me

lieser commented 10 years ago

Created the pull request (https://github.com/protz/GMail-Conversation-View/pull/826)