search

lieser / dkim_verifier

DKIM Verifier Extension for Mozilla Thunderbird
MIT License
213 stars 36 forks source link

Incompatible with compact headers add-on #40

Closed PhilCx closed 9 years ago

PhilCx commented 9 years ago

When the compact headers add-on is enabled, the verification is not performed unless the email is opened in a separate window. In the normal layout (classic, wide, or vertical) the text "DKIM:" appears on the message bar at the bottom of the TBird window, but that is the only indication that the verifier add-on is even alive.

With the compact headers add-on disabled, the DKIM message appears in full at the bottom and the header is colored. However, the menu icon does not appear in the header.

If the message is opened in a new (separate) window, full functionality appears.

lieser commented 9 years ago

I tried to reproduce this but was not able to (DKIM Verifer 1.2.1 and CompactHeader 2.0.8).

What version of the add-ons are you using? Are any errors shown in the error console?

PhilCx commented 9 years ago

By the way, I stated before that when compact header is disabled, the menu does not appear in the header. That is false. I didn't notice until later, it appears as a button rather than an icon.

I tried to reproduce this but was not able to (DKIM Verifer 1.2.1 and CompactHeader 2.0.8).

What version of the add-ons are you using? Are any errors shown in the error console?

I am using the identical versions (DKIM Verifer 1.2.1 and CompactHeader 2.0.8). There are no errors in the error console. In the "all" tab of the error console, nothing at all appears until I open the message in a new window.

Perhaps another add-on is also involved. I have:

Compact Header 2.0.8 Correct Identity 1.4.3 DKIM Verifier 1.2.1 Extra Folder Columns 1.1.5 Signature Switch 1.6.12 Minimize to Tray Revived (MinTrayR) 1.1.2

lieser commented 9 years ago

Could you please enable debugging in the add-on and set the following preference in Thunderbird to true: javascript.options.showInConsole

Is now something shown in the error console?

PhilCx commented 9 years ago

Could you please enable debugging in the add-on and set the following preference in Thunderbird to true: |javascript.options.showInConsole|

Is now something shown in the error console?

I have attached a screenshot of the contents of the error log after changing the javascript option, and selecting your signed email. Debug was already enabled.

lieser commented 9 years ago

I don't see any screenshot added in your post. I guess you have to make the post on github to add it and not by replying via e-mail. You could also sent the screenshot to dkim.verifier.addon@gmail.com.

lieser commented 9 years ago

Thanks for the screenshot, I will let you know then this is fixed.

lieser commented 9 years ago

This is now fixed in the pre-release 1.3.0pre5. You can download it from https://github.com/lieser/dkim_verifier/releases.

If you do not want to install a unreview version you could also customize the header and ad the other actions button. This should prevent the error form showing up even without the fix.