search

lievendoclo / Valkyrie-RCP

A fork from http://www.gitorious.org/valkyrie-rcp
Apache License 2.0
23 stars 10 forks source link

Port into Valkyrie the nice Help support of Spring RCP #10

Closed bravegag closed 11 years ago

bravegag commented 11 years ago

Hello,

The nice quick support for Help documentation was apparently not ported into Valkyrie. I mean the implementation of org.springframework.richclient.command.support.HelpContentsCommand.

The configuration in the original Spring RCP implementation was:

This by convention would look for the appropriate files and create a nice accessible help documentation.

PS: I'm interested in contributing to the project, I need to build a new GUI from scratch on top of a good architecture and Valkyrie is the best I could find. Let me know whether is ok to get write access.

cmadsen commented 11 years ago

Any help is appreciated.

I would prefer to take in changes as pull requests?

bravegag commented 11 years ago

How does it work with pull requests? is it like branching in subversion? what exactly I have to do? Thank you.

Can I not simply send patches instead?

cmadsen commented 11 years ago

Fork Valkyrie-RCP via github.

Checkout/clone your fork and do the changes and commit them back to the fork at github.

Then create a pull request (using github) as described here https://help.github.com/articles/creating-a-pull-request and here https://help.github.com/articles/using-pull-requests

Once I receive the pull request I will review it and merge it into Valkyrie-RPC.

bravegag commented 11 years ago

OK I got the HelpContents implemented up and running as in Spring RCP. I also integrated it into the simple sample and works. I will find time after lunch to go through the fork/merge back process. helpisback