search

lievendoclo / Valkyrie-RCP

A fork from http://www.gitorious.org/valkyrie-rcp
Apache License 2.0
23 stars 10 forks source link

Remove @Configurable from code #14

Closed lievendoclo closed 9 years ago

lievendoclo commented 10 years ago

With the migration of Spring 3.0 we changed the servicelocator in favor of Spring's @Configurable system. In hindsight, this may not have been the right call. This makes testing quite difficult without a Spring container and it requires the build and IDE to support compile-time weaving of aspects.

My alternative would be to add a repository class that has a static reference to the applicationconfig that is assigned at startup of the application. This static reference can then be used to use managed services in non-managed beans.

lievendoclo commented 10 years ago

I tried it out on a branch and it works perfectly. It also looks like it speeds up the framework quite a bit. See the no-aspectj branch for the code.

lievendoclo commented 10 years ago

Just finished the branch and it's up to speed with the master branch

lievendoclo commented 9 years ago

Fixed in 2.0 branch