search

lifadev / archive_aws-lambda-go-shim

Author your AWS Lambda functions in Go, effectively.
https://github.com/eawsy/aws-lambda-go-shim
Apache License 2.0
789 stars 66 forks source link

add :Z to Docker volume mounts for SELinux #46

Closed masneyb closed 6 years ago

masneyb commented 6 years ago

When running the sample Makefile on a host with SELinux enabled (Fedora 27 in my case), the Docker container is not able to access the files that are mapped into the container via the volumes. This is due to SELinux on the host not having the files labeled correctly. Adding a :Z to the end of the volume mounts will correct this issue. See https://www.projectatomic.io/blog/2016/03/dwalsh_selinux_containers/ for more details about the :Z and :z options that are available. These options are silently ignored for hosts that do not have SELinux enabled (including OS/X).

Signed-off-by: Brian Masney masneyb@onstation.org

lion3ls commented 6 years ago

Works on Windows 10 👍 too

masneyb commented 6 years ago

Is there anything further that I need to do to have this pull request merged?

Brian

fsenart commented 6 years ago

Hi @masneyb,

So sorry for the delay, it will certainly be merged tomorrow and you have not to do anything else, thank you very much for your contribution.