search

lifadev / archive_aws-lambda-go-shim

Author your AWS Lambda functions in Go, effectively.
https://github.com/eawsy/aws-lambda-go-shim
Apache License 2.0
789 stars 66 forks source link

Add instructions to create a role #6

Closed tleyden closed 7 years ago

tleyden commented 7 years ago

On my first attempt to follow README, I got:

An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The role defined for the function cannot be assumed by Lambda.

and thought I did something wrong or missed a step, had to google .. and the above worked for me!

fsenart commented 7 years ago

@tleyden in fact when you create your first Lambda, if you use the AWS console, the basic_execution_role is created for you.
Your PR is a very good addition as it allows to anyone to fully deploy the Lambda without any prior (supposed) config.

I've left you a few comments on the code :wink:

fsenart commented 7 years ago

You should also update the TOC in your PR :wink:

tleyden commented 7 years ago

Thanks! All of these changes make sense, thanks for the explanations. Pushed up a few commits.

fsenart commented 7 years ago

Thanks a lot for your PR :wink: