lifan0127 / ai-research-assistant

Aria is Your AI Research Assistant Powered by GPT Large Language Models
GNU Affero General Public License v3.0
794 stars 33 forks source link

Change the "Shift + R" activation shortcut #6

Closed WttBe closed 7 months ago

WttBe commented 1 year ago

As Shift is also used in combination with letters for writing capital case, it might be worth changing the activation shortcut for a less used combination of keys, or let everyone choose the shortcut (s)he wants to work with.

lifan0127 commented 1 year ago

Thanks for the suggestion. This seems to be a reasonable addition as we move beyond MVP.

WttBe commented 1 year ago

Thanks a lot!

31SFX4 commented 1 year ago

Can you also add some other method to activate it, like an entry in the context menu or a button in the toolbar, please?

odebroqueville commented 1 year ago

May I kindly suggest adding a setting (text box) in the plugin's preference pane where we can input the keyboard shortcut combination that we would like to use.

inspiredearth commented 7 months ago

I agree with this suggestion. Using SHIFT-R is not recommended as it is a common key combination.

As the risk of stating the obvious ... SHIFT-[anything] is generally not recommended, as SHIFT is system level modifier (aka. a “shortcut”) for all existing keys (capitalisation of letters, and symbols on number keys, etc.).

huachuman commented 7 months ago

Why is it shift? Does the developer realize that any time someone is writing inside the app, for example writing a title or correcting metadata, if they hit Shift+R while writing to create a capital R, it activates the plugin?

I seriously question the sanity of this developer for using this shortcut and not allowing us to change it. In all honesty this is one of the most mentally insane things I've seen a developer do in twenty years of using software.

The developer seems busy releasing all kinds of updates but has not stopped to look at and fix this one extremely fundamental issue they promised to fix many months ago? This is supremely easy to fix, yet nothing has changed.

lifan0127 commented 7 months ago

It is possible to customize the shortcut key combo now. You can also use the Aria toolbar button. Please give it a try.

https://github.com/lifan0127/ai-research-assistant/releases/latest

image

image

inspiredearth commented 7 months ago

Thank you @lifan0127, I’ve tested this out, and it appears to work well. Problem resolved, as far as I’m concerned.

I would, however, suggest making something other than SHIFT-R the default. You could, for instance, make the default SHIFT-CONTROL-R, for example. There’s really no point in making it only SHIFT-... as this causes issues of unintended Aria activation for the user.

lifan0127 commented 7 months ago

@inspiredearth Thank you for your feedback. I agree that "Shift + R" is problematic and was a poor decision on my part. However, for now, I will need to keep it as the default for the sake of backward compatibility, to prevent confusion among existing users.

huachuman commented 7 months ago

That makes no sense, but whatever. It's not my problem.

WttBe commented 7 months ago

Thanks for the work, @lifan0127! Clearly, you are taking comments into account :)