Closed EilidhRoss1 closed 1 year ago
Name | Link |
---|---|
Latest commit | 022c846f510fee8b0b8c170917297ef88b78e6da |
Latest deploy log | https://app.netlify.com/sites/zesty-liger-3a5c29/deploys/637cffce09f9d1000978a59c |
@EilidhRoss1 first always well done on moving forward. 90% looks good here. Review comments below and some things i can't comment on the file directly
.DS_Store
files in the commit. We'll need to remove them. Actioned: https://github.com/life-itself/community/pull/202/commits/2d7cc2f77ab017c8fd48242fe2e99330934bc4a9 Images - this is a big one and something we need in the tutorial for people working with the vault in general
assets/tao
for tao stuff and assets/notebook
for notebook stuff.assets/tao/xyz.png
rather than, say, assets/tao/governance/xyz.png
One last ❗ important point: i've renamed notebook
to notes
- pull the latest version of the repository to see the change.
Thanks Rufus, am travelling today so my work day will be a bit disrupted but will try and get all this done today
@EilidhRoss1 hi, no problem and as per my comment in the issue #182 i think best to start with a smaller pull request with say 5 top priority files (i think spreadsheet is in priority order) and then once that is good we move to rest. Does that sound good?
@EilidhRoss1 there are a lot of conflicts here. I think you are going to need to close this pull request and start a new one. Is that possible?
@rufuspollock sorry I'm still learning about all this, would that meaning starting again? I can do that, just want to make sure I'm understanding.
I think starting again at this point is probably easiest
Ok, will do 👍
WONTFIX. Replace by other PRs.
have moved contents of tao.lifeitself.org (https://github.com/life-itself/tao) to lifeitself.org/tao (i.e. vault/tao in this repo). Have taken action based on: https://docs.google.com/spreadsheets/d/13RVMrZ02Rw6a1BtftIUO4v7R7rXt5_phQLR4rHa343M/edit#gid=453234015