search

life-itself / web3

Making sense of web3 & crypto. Introduction to key concepts and ideas. Rigorous, constructive analysis of key claims pro and con. A look at the deeper hopes and aspirations.
https://web3.lifeitself.org/
Creative Commons Zero v1.0 Universal
1.75k stars 193 forks source link

Navbar responsiveness adjsutment + sticky #166

Closed olayway closed 2 years ago

olayway commented 2 years ago

Closes: #165

Changes

Adjusted Nav component's responsiveness + making it sticky

image image image image image

netlify[bot] commented 2 years ago

Deploy Preview for boring-fermat-22cb64 ready!

Name Link
Latest commit 75e63c6bbf0ec60e78431a2130da5c8bb33b7f14
Latest deploy log https://app.netlify.com/sites/boring-fermat-22cb64/deploys/628c7b48567b5e0008811fcf
Deploy Preview https://deploy-preview-166--boring-fermat-22cb64.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

olayway commented 2 years ago

You may need to add a z-index as the navbar isn't on top after the hero section. Also not really sure if need the sticky for larger screens.

Thank you @khalilcodes for spotting that! :smiley: I've just fixed it. As for making the whole navbar sticky: I've made it sticky so that it plays well with the LHS sidebar and RHS ToC I'm currently working on, i.e. so that all three elements stay in the same place and only the content is scrollable.

And again: thank you for the blazing-fast review! :zap:

khalilcodes commented 2 years ago

As for making the whole navbar sticky: I've made it sticky so that it plays well with the LHS sidebar and RHS ToC I'm currently working on, i.e. so that all three elements stay in the same place and only the content is scrollable.

RIght makes sense. Looks good to go. 👍