lifeart / demo-ember-vite

Ember.js running on Vite
https://stackblitz.com/github/lifeart/demo-ember-vite
MIT License
57 stars 5 forks source link

bump Vite to v5 #87

Closed lifeart closed 10 months ago

lifeart commented 10 months ago

With vite 5 it seems virtual modules does not work anymore inside node_modules, so, we need to patch ember-intl to not break.

netlify[bot] commented 10 months ago

Deploy Preview for ember-vite ready!

Name Link
Latest commit cfa32308ef251608d1316a12e91859f5996b4d00
Latest deploy log https://app.netlify.com/sites/ember-vite/deploys/6575d6dac8d93a0009b23369
Deploy Preview https://deploy-preview-87--ember-vite.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 10 months ago

Code Coverage Report

Coverage after merging vite-5 into master

97.66%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
addons
   ember-simple-auth.ts12, 16
.../Bootstrap
   index.ts50
.../Hot
🔴   index.ts ⬆️ 17.27%72.7387.5096, 97, 98, 99, ...
config
   registry.ts85, 99
   router.ts98.0897, 98
   utils.ts93.5557, 58, 59, 60, ...
helpers
   memory-usage.ts12, 18, 20, 30, ...
modifiers
   click-tracker.ts20, 21
lifeart commented 10 months ago

Just note for readers, references: I see bundle size grow for this update:

vite v4.3.9 image

vite v5.0.7 image