lifeart / els-addon-typed-templates

Ember templates linting / autocomplete, based on Typescript language server
30 stars 3 forks source link

Odd Autocomplete from Glimmer component JSDoc #21

Open pdud opened 4 years ago

pdud commented 4 years ago

As you know, I'm a big fan of your add-on. Thanks so much!

Using JSDoc, it is possible to autocomplete and get malformed suggestions.

Screen Shot 2020-05-23 at 4 58 23 PM

Steps

  1. Type ``{{typo
  2. Trigger autosuggestions
/**
 * @typedef {Object} Args
 * @property {Number} value
 * @property {Function} onChange
 * @extends Component<Args>
 */

export default class NumberInput extends Component {
  ...
}
lifeart commented 4 years ago

@pdud looks like arguments autocomplete from language-server win over addon autocomplete. Will check it

lifeart commented 4 years ago

looks like issue from meta-extractor - https://github.com/lifeart/ember-meta-explorer/blob/master/src/utils/js-utils.ts#L69