search

lifeart / vsc-ember-syntax

Ember Syntax For VS Code
https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-glimmer-syntax
MIT License
12 stars 8 forks source link

Properites & Arguments marked as `support.function` #46

Open evoactivity opened 1 year ago

evoactivity commented 1 year ago
Enabled Disabled
image image

I like that data access is colored but I don't like that it is marked as a function, had reports this is putting some people off using this extension.

Not sure when I'll be able to dig into this but just creating an issue so I don't forget.

lifeart commented 1 year ago

Hi @evoactivity, thank you for report, but it's only about "how it's looks like", I skipping semantic here prior to colors. In textmate scope is matched to colors, and it's really hard to get proper color and relative scope :)

Here is "customization" section https://github.com/lifeart/vsc-ember-syntax#customizing-the-theme, function color could be changed to anything.

evoactivity commented 1 year ago

I think the problem is these are not actually functions, so shouldn't be highlighed as functions at all. You can see with the extension disabled they are properly marked as variables/parameters.

This is where that is happening in the syntax https://github.com/lifeart/vsc-ember-syntax/blob/55ca6981204a1f3934b55057a5a7abbab66a1d8e/syntaxes/handlebars.tmLanguage.json#L210

lifeart commented 1 year ago

I don't see problem here, I mean, if color is confusing - it could be manually changed. You may try to specify 'different' scopes, but it likely gonna look so sad (in terms of colouring)

evoactivity commented 1 year ago

I agree to be honest, visually I think it's fine as it is. I was told though people are still using the unmaintained vscode-glimmer because they don't like the property access being the same colour as a js/ts function when they are not functions. I would like to remove roadblocks to people using this extension, even if it seems trivial.

You're probably right and I might not be able to find a satisfying approach to colour them differently, but I'd still like to play around with it and see if I can't do something that satisfies everyone.

lifeart commented 1 year ago

@evoactivity you may propose coloring ovverides (as in readme) and we could offer it as themes.

evoactivity commented 1 year ago

Cool. I won't have time to visit this immediately but it's in my backlog :)