search

lifeart / vsc-ember-syntax

Ember Syntax For VS Code
https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-glimmer-syntax
MIT License
12 stars 8 forks source link

Change handlebars to ember-handlebars so linguist scope tests pass #48

Closed evoactivity closed 9 months ago

evoactivity commented 9 months ago

GitHub Linguist will not merge the glimmer syntax because our handlebars scope name clashes with actual handlebars.

https://github.com/github-linguist/linguist/pull/6578#issuecomment-1843157976

I've updated the scope names to ember-handlebars which should make it safe for linguist to merge.

I've quickly tested this change in vscode and all seems to be highlighting correctly but would appreciate someone else testing before we merge this PR.

The next release of linguist is 12 December so getting this merged and released asap would be good.

lifeart commented 9 months ago

Hi @evoactivity! Thank you for PR! Changes seems good. Quick search on codebase gives me this dependency match:

image

Are we good that changing things here not break prettier scope?

evoactivity commented 9 months ago

If I search in the prettier repo for that I only find the string in a test snapshot.

https://github.com/search?q=repo%3Aprettier%2Fprettier%20text.html.handlebars&type=code

I believe that's generated at build time and pulled in from https://github.com/ikatyang/linguist-languages

For what it's worth prettier seems to be functioning correctly in my test repo.