Fix: Fix GitHub and original textmate when using undeclared default export of a template in GTS/GJS

lifeart / vsc-ember-syntax

Ember Syntax For VS Code

https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-glimmer-syntax

MIT License

12 stars 8 forks source link

Fix: Fix GitHub and original textmate when using undeclared default export of a template in GTS/GJS #77

Closed evoactivity closed 7 months ago

evoactivity commented 7 months ago

Apparently the order of the patterns array matters a lot to textmate. GitHub seems to closely match the original textmate highlighting engine compared to any other implementation (which were highlighting correctly without this)

@lifeart don't merge this until I've tested shikijs, I want to ensure this fix isn't breaking everywhere else this is used.

I'll post a reply once I'm happy everywhere is working as intended.

evoactivity commented 7 months ago

Shikijs is fine

VSCode is fine

TextMate is fine

@lifeart Should be good to merge

lifeart commented 7 months ago

@evoactivity thank you for contribution!