search

lifeart / vscode-ember

VSCode client for the Ember Language Server
https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-ember-unstable
Other
30 stars 9 forks source link

`glimmer-engine` error after fixing helper parentheses deprecation #23

Closed charlesfries closed 3 years ago

charlesfries commented 3 years ago

Per this deprecation: https://deprecations.emberjs.com/v3.x/#toc_argument-less-helper-paren-less-invocation

Helpers w/o arguments that are passed to components should be wrapped in parentheses. This template:

<SomeComponent @arg={{array}} />

becomes:

<SomeComponent @arg={{(array)}} />

However, when I apply this fix to my own app, I see the following error in VSCode's problems drawer:

Expecting 'ID', 'STRING', 'NUMBER', 'BOOLEAN', 'UNDEFINED', 'NULL', 'DATA', got 'OPEN_SEXPR'

The error goes away if UELS is disabled. Any ideas?

DEBUG: -------------------------------
DEBUG: Ember                 : 3.27.5
DEBUG: Ember Data            : 3.27.1
DEBUG: Ember Model Validator : 3.10.0
DEBUG: Ember Simple Auth     : 4.0.0
DEBUG: Model Fragments       : 5.0.0-beta.2
DEBUG: -------------------------------

Screenshot 2021-09-15 154231

lifeart commented 3 years ago

Hi @charlesfries! Could you share ember-template-lint version you have on project?

lifeart commented 3 years ago

It’s error from https://github.com/ember-template-lint/ember-template-lint/issues/1963, can’t fix in uELS level (in long term), but, patch-package or ember-template-recast dependency pinning may help

charlesfries commented 3 years ago

ember-template-lint@3.7.0

Closing in favor of that other issue. Thanks again @lifeart !