Closed gvocale closed 4 years ago
@gvocale I can't see difference :) UELS - don't touching syntax higlighting.
Higlighting - https://github.com/lifeart/vsc-ember-syntax
But, we don't rewrite JS parsing logic, only extend it https://github.com/lifeart/vsc-ember-syntax/blob/master/syntaxes/inline-hbs.json
Now I see, getters color, sample
import Component from '@glimmer/component';
import { inject as service } from '@ember/service';
interface Args {
foo?: string
}
export default class HeaderCartComponent extends Component<Args> {
@service('cart') cart;
get hasCategory() {
return this.args.foo?.toString();
}
foo() {
}
}
it's very strange
Issue appears right after ts language features loading, I think it's related to "ordering", I see same behavour without "UELS", all you need to do - wait until ts features will be loaded.
(els already loaded ^)
(ts loaded ^)
disabled UELS and fully loaded TS
@gvocale try disable UELS and wait for 1 minute, you should see same error
@lifeart my problem is not with the following:
But rather with the following: ON
OFF
Using optional chaining seem to throw off the color of few lines of code after.
Right now I have UELS off and I haven't been running anymore in the issue. To be honest, other extensions as well were causing the same issue. Right now I have the following extensions enabled:
It looks like vs code issue itself
closing it as not related to extension
When using
Unstable Ember Language Server
, using optional chaining seem to affect syntax highlighting.With Unstable Ember Language Server OFF
With Unstable Ember Language Server ON