lifechurch / k8s-deploy-helper

k8s-deploy-helper is a tool to help build and deploy containerized applications into Kubernetes using GitLab CI along with templated manifest files.
MIT License
141 stars 30 forks source link

kubeval should evaluate the rendered templates #21

Closed nabadger closed 5 years ago

nabadger commented 5 years ago

In the deploy script should kubeval not run against the yaml files in rendered in /tmp/kubernetes?

Currently it runs against files in ./kubernetes in the project repo.

This crashes for me, because I'm using a $PORT environment (in my project manifests) via the CI/CD pipeline variables (which envsubst will set).

WillPlatnick commented 5 years ago

@nabadger It absolutely should, I have a branch in that fixes that that should release this week.

WillPlatnick commented 5 years ago

In the meantime, 3.0.0 is unaffected.

nabadger commented 5 years ago

Thanks :)

WillPlatnick commented 5 years ago

This is fixed in 3.1.0.