Don't overwrite existing env vars

lifechurch / k8s-deploy-helper

k8s-deploy-helper is a tool to help build and deploy containerized applications into Kubernetes using GitLab CI along with templated manifest files.

MIT License

141 stars 30 forks source link

Don't overwrite existing env vars #49

Open bbelyeu opened 4 years ago

bbelyeu commented 4 years ago

when pulling in Gitlab secrets

bbelyeu commented 4 years ago

@chrisvaughn and @justin-richert

chrisvaughn commented 4 years ago

I think there a couple of other places that would need this check. get_secrets_for_creation specifically but I see other places that are getting SECRET_ env vars and processing them.

bbelyeu commented 4 years ago

yeah, I'm not sure if the last one is actually needed or not...

bbelyeu commented 4 years ago

but I've done the same hack in all the SECRET_ parsing locations