search

lifeemotions / knx.net

KNX.net provides a KNX API for .NET
MIT License
101 stars 47 forks source link

Is this repo completed/stable? #29

Closed bitver closed 7 years ago

bitver commented 7 years ago

For example, I mean this: https://github.com/lifeemotions/knx.net/blob/master/src/KNXLib/KnxReceiverTunneling.cs#L178-L186 knxDatagram is never used, are you going to finish writing or just forgot to remove this variable?

abelsilva commented 7 years ago

I don't understand, the knxDatagram is used in 3 more places just after being declared (in same method). Two times to log an info message. One time to declare the channel ID (without this one the connection wouldn't work).

Yes, the comparisons could be done directly using the byte array, but it wouldn't be easy to read

Also, if the header is needed for something else, it is already built.