lifegadget / ember-cli-bootstrap-sassy

a fork of ember-cli-bootstrap-sass but without any dependencies on the now defunct bootstrap_for_ember
MIT License
62 stars 33 forks source link

Glyphicons showing up as emoticons #25

Closed hoIIer closed 8 years ago

hoIIer commented 9 years ago

Hello,

I recently discovered that the glyphicons dont seem to be loading anymore and show as emoticons on ios.. Not sure what changed that made this happen but also no idea how to fix!

Any suggestions? Im using this repo + bootstrap-sass-official 3.3.5

yankeeinlondon commented 9 years ago

@erichonkanen are you setting the configuration to something other than the default? By default it should load the fonts for glypicons: https://github.com/lifegadget/ember-cli-bootstrap-sassy/blob/master/index.js#L38-L45

hoIIer commented 9 years ago

@ksnyde

I've been loading them via my Brocfile:

/* global require, module */

var EmberApp = require('ember-cli/lib/broccoli/ember-app');

var app = new EmberApp();

// Use `app.import` to add additional libraries to the generated
// output files.
//
// If you need to use different assets in different
// environments, specify an object as the first parameter. That
// object's keys should be the environment name and the values
// should be the asset to use in that environment.
//
// If the library that you are including contains AMD or ES6
// modules that you would like to import into your application
// please specify an object with the list of modules as keys
// along with the exports of each module as its value.

// Bootstrap
app.import('bower_components/bootstrap-sass-official/assets/javascripts/bootstrap.js');
app.import('bower_components/bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.woff2', {
  destDir: 'fonts/bootstrap/'
});

// Slideout.js
app.import('bower_components/slideout.js/dist/slideout.min.js');

// Modernizr
app.import('vendor/modernizr.js');

module.exports = app.toTree();
hoIIer commented 9 years ago

seems like changing back to 0.0.12 from 0.0.18 works

kulpae commented 9 years ago

Updating to ember-cli-sass 4.0.1 fixed that problem for me. (I had 3.3.0) Latest bootstrap utilizes the '@at-root' directive which came with sass 3.3, but had a bug with '@font-face' until 3.3.4.

yankeeinlondon commented 9 years ago

Ahh great. I'll get this updated over the next day or two (on the road at the moment).

hoIIer commented 9 years ago

I'm still having issues.. can you guys clarify which bower and npm packages I need to use this?

So far I have tried via bower: bootstrap-sass, and bootstrap-sass-official (is that the same lib? cant find it on git now)

Then in npm there is this package as well as ember-cli-sass. What about brocolli-sass which ive also seen?

Ive confirmed that everything works fine with version 0.0.12 of this and 0.3.4 of bootstrap-sass-official.

yankeeinlondon commented 9 years ago

bootstrap-sass-official is the old repo name but they are functionally mirrors of each other; better to use bootstrap-sass now though.

yankeeinlondon commented 9 years ago

You should include ember-cli-sass@4.0.1 to get SASS into your project, this is a dependency for Bootstrap SASS to work for you.

elidupuis commented 9 years ago

I've updated to ember-cli-sass@4.0.1 and Bootstrap is being compiled properly now (I can see the Glyphicon files being requested). The problem now is that it's looking in /assets/fonts but the actual font files are placed in /fonts (this is all inside the /dist folder, obviously).

Is there configuration for this?

elidupuis commented 9 years ago

Actually, it looks like the issue is that the font files are placed in /assets/fonts/bootstrap/ but the CSS is just pointing to /assets/fonts/.

Actual location image

Requested location image

elidupuis commented 9 years ago

Disregard my previous comments. I didn't realize there was a $icon-font-path override in our code from our previous set up. :-1: :disappointed:

yankeeinlondon commented 8 years ago

I'm closing this but if you're still experiencing an issue please let me know