search

lifegadget / ember-cli-bootstrap-sassy

a fork of ember-cli-bootstrap-sass but without any dependencies on the now defunct bootstrap_for_ember
MIT License
62 stars 33 forks source link

New feature: adding Bootstrap 4 #57

Open zoltan-nz opened 6 years ago

zoltan-nz commented 6 years ago

I think, there could be a config option which would determine which Bootstrap version should be wrapped in vendor.js.

Suggested config property:

bootstrapVersion: 4

In ember-cli-bootstrap-sassy v1.0.0 can be Bootstrap v4 the default.

belgoros commented 6 years ago

👍 That would be great to have Bootstrap 4 implemented with the same success: no headaches with JS components, just use Bootstrap CSS classes (no need to use special tags s it is the case with ember-bootstrap or ember-cli-foundation-sass add-ons. Waiting with impatience :). Unfortunately, there are some new dependencies introduced with BS4 (popper.js) and no more glyphicons available.

yankeeinlondon commented 6 years ago

I think there are enough differences in philosophy as well as structure to just have a separate repo for this. I created a BS4 addon a year ago or so called ui-bootstrap that did this. I have stopped development on that but I just did a search on emberaddons and seems there's a recently updated ember-cli-bootstrap-4 out there.

yankeeinlondon commented 6 years ago

If anyone is interested in taking over as maintainer for ui-bootstrap or ember-cli-bootstrap-sassy I'm happy to pass the responsibility over. I feel my current time on Ember is too limited to serve it full justice.

belgoros commented 6 years ago

Thank you, Ken for the link. Unfortunately it even fails to boot.

yankeeinlondon commented 6 years ago

Bummer. Well my ui-bootstrap should still work if you need BS4 in a hurry.

belgoros commented 6 years ago

Thank you, Ken. They've fixed it.