lifegadget / ui-slider

A visually attractive slider for ambitious Ember apps
https://ui-slider.firebaseapp.com/
MIT License
30 stars 39 forks source link

Old dependency to seiyria/bootstrap-slider#6.0.17 #33

Open theloi opened 7 years ago

theloi commented 7 years ago

Hi guys

I cannot figure out why this happens then again I'm fairly new to ember. Is this an 'issue' or am I doing something wrong? Any help appreciated!

When I install via the ember CLI I get the addon with an old version of bootstrap-slider:

ember install ui-ember-slider Installed packages for tooling via npm. installing ui-ember-slider install bower package seiyria-bootstrap-slider cached https://github.com/seiyria/bootstrap-slider.git#6.0.17 Installed browser packages via Bower. Installed addon package.

On the other hand when I install the npm package directly I get the newest version of bootstrap-slider:

bower install ui-slider bower ui-slider# not-cached https://github.com/lifegadget/ui-slider.git# bower ui-slider# resolve https://github.com/lifegadget/ui-slider.git# bower ui-slider# download https://github.com/lifegadget/ui-slider/archive/0.5.0.tar.gz bower ui-slider# extract archive.tar.gz bower ui-slider#* resolved https://github.com/lifegadget/ui-slider.git#0.5.0 bower showdown#^1.4.3 not-cached https://github.com/showdownjs/showdown.git#^1.4.3 bower showdown#^1.4.3 resolve https://github.com/showdownjs/showdown.git#^1.4.3 bower seiyria-bootstrap-slider#^9.7.2 not-cached https://github.com/seiyria/bootstrap-slider.git#^9.7.2 bower seiyria-bootstrap-slider#^9.7.2 resolve https://github.com/seiyria/bootstrap-slider.git#^9.7.2 bower showdown#^1.4.3 download https://github.com/showdownjs/showdown/archive/1.6.4.tar.gz bower seiyria-bootstrap-slider#^9.7.2 download https://github.com/seiyria/bootstrap-slider/archive/v9.8.0.tar.gz bower showdown#^1.4.3 extract archive.tar.gz bower seiyria-bootstrap-slider#^9.7.2 extract archive.tar.gz bower showdown#^1.4.3 resolved https://github.com/showdownjs/showdown.git#1.6.4 bower seiyria-bootstrap-slider#^9.7.2 resolved https://github.com/seiyria/bootstrap-slider.git#9.8.0 bower ui-slider#^0.5.0 install ui-slider#0.5.0 bower showdown#^1.4.3 install showdown#1.6.4 bower seiyria-bootstrap-slider#^9.7.2 install seiyria-bootstrap-slider#9.8.0

ui-slider#0.5.0 bower_components/ui-slider ├── seiyria-bootstrap-slider#9.8.0 └── showdown#1.6.4

showdown#1.6.4 bower_components/showdown

seiyria-bootstrap-slider#9.8.0 bower_components/seiyria-bootstrap-slider

theloi commented 7 years ago

I found why this happens: In the blueprint index.js it installs an old version of the bower package:

afterInstall: function() {
        return this.addBowerPackagesToProject([
      { name: 'seiyria-bootstrap-slider', target: '~6.0.6'  }
    ]);
    }

Is this intentionally? It does not make any sense since the bower.json states:

"dependencies": {
    "seiyria-bootstrap-slider": "^9.7.2",
    "showdown": "^1.4.3"
  },

...which is more like what I am looking for :) !