search

lifelike / countersheetsextension

Inkscape extension for the layout of sheets of cards, tiles, or counters for boardgames.
Other
235 stars 27 forks source link

Add option to set registration marks distance from components #68

Closed ernierasta closed 3 years ago

ernierasta commented 3 years ago

Hi, solves #65. I was not sure how to call option to set distance of cutting (registration) marks ... Will happily correct whatever is needed. :-)

lifelike commented 3 years ago

Looks good, except you forgot to update the margins calculation around line 1400 or so to include this extra space. That has to be updated or the components plus registration lines will not fit inside of the page when there is no cs_layout layer.

Happy to merge once that is fixed. :)

ernierasta commented 3 years ago

Thank you for looking at it. Fixed.

ernierasta commented 3 years ago

I am sure you know how to solve this conflict(that is a pity there is no mechanism I am aware of, to propose conflict resolving), but it should by like that:

            positions = [Rectangle(0.0,
                                   0.0,
                                   docwidth,
                                   docheight)]
            margin = max(self.registrationmarkslen + self.registrationmarksdist,
                         self.outlinedist)
lifelike commented 3 years ago

No worries. I solved the conflicts last night, just got interrupted before pushing it back to github.