search

lifelike / hexmapextension

Inkscape extension for creating hex grids suitable for boardgame maps.
129 stars 16 forks source link

Resolves #34. Update python script for Inkscape 1.0, breaks 0.9 support #36

Closed UnicodingUnicorn closed 4 years ago

lifelike commented 4 years ago

Thank you!

It looks like there are some similarities to what I made on the support_inkscape_1.0, but also some things that are different (and my version did not work, so ...).

It looks like it would not be impossible to make it also work for 0.9?

UnicodingUnicorn commented 4 years ago

Yikes, I didn't know you were also working on it, sorry. Inkscape changed the location of some of the functions used, and also changed how the type of the arguments is passed. So unless there is a way of differentiating Inkscape version so different code can be run, I can't think of a way to support both versions with the same script.

lifelike commented 4 years ago

My work on 1.0-support failed. Not sure what was wrong. Looks like you did far fewer changes than I did. If it works I will be happy to scrap my branch.

In the past when the API changed it was possible to just look at if some function was present to decide which one to call.

UnicodingUnicorn commented 4 years ago

Funnily enough, the code to do it was right above the place I changed stuff.

lifelike commented 4 years ago

Merged this and removed the warning from the README about 1.0 not working.

I do not have 1.0 installed yet. It seems like this works with 0.92.3 though. Thanks for sorting that out, UnicodingUnicorn.