lifelong-learning-systems / tella

Framework for Training & Evaluating Lifelong Learning Agents (TELLA)
MIT License
3 stars 2 forks source link

Should task and variant names be optional in event handlers? #283

Open ginoperrotta opened 2 years ago

ginoperrotta commented 2 years ago

In our agent class, the event handlers look like:

    def task_variant_start(
        self,
        task_name: typing.Optional[str],
        variant_name: typing.Optional[str],
    ) -> None:

Why are the names optional? Do we use that? If not, should we remove it?

coreylowman commented 2 years ago

Oh yeah that's from the very beginning when we were thinking it could be configurable whether agents receive task/variant information. It's currently not used at all! If we add a configuration option to turn it on/off then we can keep it, otherwise can probably delete it