lifeomic / app-tools

Common utilities for PHC app development
MIT License
0 stars 0 forks source link

feat: add confirm signup method #84

Closed jkdowdle closed 1 year ago

jkdowdle commented 2 years ago

Motivation

~based on #83~

We want to provide a way to sign-up Platform users easily, especially in 3rd party apps like Preventia.

aecorredor commented 2 years ago

@jkdowdle btw, I noticed this repo is not enforcing approvals before merging. We should probably enable those in the GitHub settings for this repo.

jkdowdle commented 1 year ago

@jkdowdle btw, I noticed this repo is not enforcing approvals before merging. We should probably enable those in the GitHub settings for this repo.

do you still see this? I wonder if it was because before this pr was referencing a branch other than master

loscm commented 1 year ago

Requested review from a random @lifeomic/security team member, @bishopb, due to term: token.

This review is not blocking and is for broader awareness. Consider if this change requires deeper security review and ask when it is necessary.

aecorredor commented 1 year ago

@jkdowdle btw, I noticed this repo is not enforcing approvals before merging. We should probably enable those in the GitHub settings for this repo.

do you still see this? I wonder if it was because before this pr was referencing a branch other than master

Maybe it was that. I can't tell now since it already had Rob's approval.

rob-snyder commented 1 year ago

@jkdowdle btw, I noticed this repo is not enforcing approvals before merging. We should probably enable those in the GitHub settings for this repo.

do you still see this? I wonder if it was because before this pr was referencing a branch other than master

Maybe it was that. I can't tell now since it already had Rob's approval.

I saw it as blocked waiting for review prior to my approval, so I think it was the fact that it was referencing a different branch

jkdowdle commented 1 year ago

Thank you @aecorredor @rob-snyder!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: